rudders / homebridge-http

HTTP Plugin for Homebridge
Apache License 2.0
178 stars 109 forks source link

Update index.js #44

Closed cybertza closed 7 years ago

cybertza commented 8 years ago

found that it fixed my code, but i also handle data NaN later in my code, so it may be that it would help with some issues, i do find that data = NaN will set state to 0 irrespective of what going on.

@issue 40 https://github.com/rudders/homebridge-http/issues/40

so at least this helps the bridge not terminate, albeit it ends up switching most devices off over time as it recieves NaN code, that may very well be how i am presenting data from my device.

NovaGL commented 8 years ago

You are confusing me with all these Pull requests you just need the one. If @rudders wants to make you a Collaborator you can do them yourself. Can you please close the non-main ones

metbosch commented 7 years ago

Now this Pull request can be closed because it conflicts with the real fix that is introduced in PR #61

gbougakov commented 7 years ago

@metbosch Actually, it doesn't :) NPM version has the great old callback(error);