search

rudders / homebridge-http

HTTP Plugin for Homebridge
Apache License 2.0
178 stars 110 forks source link

I can maintain #63

Open gbougakov opened 7 years ago

gbougakov commented 7 years ago

NPM username: georgenet I understand everything inside the code.

gbougakov commented 7 years ago

I found a bug and I know how to fix it. (In the npm version)

NovaGL commented 7 years ago

Is the bug in the github version too? Not sure If I can add you to the npm version.

If you have anything feel free to do a pull request.

gbougakov commented 7 years ago

@NovaGL Actually code in npm and github is different, but none of them are stable and homebridge crashes when it reaches here.

Problem

Line 46 says done(error); That throws an uncaught "critical" network error, as a result - homebridge crashes.

Solution

Replace done(error); with this

gbougakov commented 7 years ago

Actually IDK is it only on my server so unstable, so I had to rewrite all the plugin to make it stable?

gbougakov commented 7 years ago

@NovaGL And yep, the npm version instead of done(error); says callback(error);

NovaGL commented 7 years ago

I don't think I can add you as I am not the owner, but I can merge your requests.