rudeboybert / fivethirtyeight

R package of data and code behind the stories and interactives at FiveThirtyEight
https://fivethirtyeight-r.netlify.app/
Other
454 stars 104 forks source link

Adding the state-of-the-state dataset #56

Closed mariumtapal closed 4 years ago

mariumtapal commented 4 years ago

Adding the cleaned and documented state-of-the-state dataset to the fivethirtyeight package

rudeboybert commented 4 years ago

Hey @mariumtapal, thanks for this PR.

On top of Ben's suggestions, a couple of notes:

No 1: the data set names index and words are a little too generic. In fact, the object name words clashes with stringr::words. Could you rename these state_index and state_words?

No 2: If you look at the top of this PR #56 page, you'll see that your commits are tagged with a grey image of the GitHub OctoCat, and not your GitHub profile image:

Screen Shot 2019-11-10 at 8 26 57 AM

While seemingly innocuous, @Starryz and I discovered that if you don't fix this, your contributions to the package will not be listed on the repo's contributors page. Please

This way your work will be fully credited on the contributors page