search

rudeboybert / fivethirtyeight

R package of data and code behind the stories and interactives at FiveThirtyEight
https://fivethirtyeight-r.netlify.app/
Other
454 stars 104 forks source link

added data and documentation for the womens-world-cup-2019 datasets #59

Closed sunniraleigh closed 4 years ago

sunniraleigh commented 4 years ago

added data and documentation for the two datasets (wwc_forecasts and wwc_matches) included in womens-world-cup-2019

rudeboybert commented 4 years ago

Thanks @sunniraleigh for your work. Also remember that you don't need to delete this current PR #59 and start a new one when making changes. Just commit/push your changes and this PR will update itself.

rudeboybert commented 4 years ago

Hey @sunniraleigh, before I go over your changes, could you resolve the above merge conflict in the DESCRIPTION and NEWS.md files and commit/push them? I believe @beanumber has been suggesting students do a "git fetch upstream" type command, then fix all conflicts

beanumber commented 4 years ago

Yes, @sunniraleigh , please try this:

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork

rudeboybert commented 4 years ago

Thanks @sunniraleigh! You're now listed as a contributor: https://github.com/rudeboybert/fivethirtyeight/graphs/contributors