Adding nba raptor dataset

[rudeboybert]

Hi @danicamiguel, thanks for your PR. A couple of things right off the bat:

• Your commits are not being attributed to your GitHub user ID. See this comment for more details. You'll need to re-do your PR after running the package checks
• You should also commit pushing the resulting .rda data and .rd help files that result from building the package
• Please add your info to both NEWS.md and DESCRIPTION as well. See those files as they currently are in the master branch for examples of other students doing this.

@beanumber

[danicamiguel]

Hi @rudeboybert I have added the files and updated my commit history. Let me know if it is ok.

[beanumber]

@danicamiguel note the following WARNING on Travis:

* checking for missing documentation entries ... WARNING

Undocumented code objects:

  ‘nba_raptor’

Undocumented data sets:

  ‘nba_raptor’

All user-level objects in a package should have documentation entries.

I don't think your roxygen tags are quite right. Pay careful attention to the name of each piece of documentation.

[danicamiguel]

Hi @rudeboybert I have made changes to your comments as listed:

1. • [x] typo here: the url should be inside the text for player_id: \item{player_id}{Player ID as found on \url{https://www.basketball-reference.com/}}
2. • [X] Could you put era first in the list of variables? That way it matches order of columns in the data frame?
3. • [X] Just so we can stay consistent in coding style throughout this package, could you do this with a mutate? Ex: mutate( raptor_box_offense = NA, raptor_box_defense = NA, ... )
4. • [X] Could you do the converting to factor after you've bind_rows() the data frame? Otherwise the saved levels are off. Doing it this way yields era being a character
5. • [X] Could you do this with a select()? Again, so that we have consistency of tidyverse style for this package and not base R? Make sure to put the previous mutate() and this select() all in the same pipe %>% chain.
6. • [X] All comments for historical_raptor_XXX apply here for modern_raptor_XXX as well

[beanumber]

@danicamiguel the conflicts noted above in DESCRIPTION and NEWS.md can most likely be resolved by syncing your fork. Can you try that?

[rudeboybert]

Hey @beanumber, it seems after approving @danicamiguel's changes, I was able to resolve the merge conflict myself. Given how often DESCRIPTION and NEWS.md is changing because of all the PR merging going on, I think that it was easier for me to do it.

@danicamiguel thanks for your PR! You're now listed as a package contributor: https://github.com/rudeboybert/fivethirtyeight/graphs/contributors

[rudeboybert]

Also heads up @danicamiguel, I did a little more cleaning of your code to match the tidyverse style guide.

Strictly a style thing, nothing functional changed in your code

[beanumber]

Awesome! Thanks @rudeboybert !