foul-balls dataset tamed

rudeboybert / fivethirtyeight

R package of data and code behind the stories and interactives at FiveThirtyEight

https://fivethirtyeight-r.netlify.app/

Other

454 stars 104 forks source link

Closed aballou16 closed 4 years ago

aballou16 commented 4 years ago

I added the tamed and added the foul-balls dataset.

rudeboybert commented 4 years ago

Hi @aballou16 , thanks for your PR. A couple of things right off the bat:

Your commits are not being attributed to your GitHub user ID. See this comment for more details. You'll need to re-do your PR after running the package checks
You should also commit pushing the resulting .rd help files that result from building the package
Please add your info to NEWS.md as well. See those files as they currently are in the master branch for examples of other students doing this.

@beanumber