search

rudeboybert / fivethirtyeight

R package of data and code behind the stories and interactives at FiveThirtyEight
https://fivethirtyeight-r.netlify.app/
Other
455 stars 107 forks source link

Adding NBA_elo & NBA_elo_latest datasets #63

Closed kvanallen closed 4 years ago

kvanallen commented 4 years ago

I added the nba_elo and nba_elo_latest datasets and accompanying documentation to the FiveThirtyEight package.

rudeboybert commented 4 years ago

Tagging #53

beanumber commented 4 years ago

From Travis:

Error in data.frame(package = deps, installed = inst_ver, available = cran_ver,  : 

  row names contain missing values

@kvanallen are there row names? If so, can you remove them?

beanumber commented 4 years ago

@kvanallen can you make these changes? You also may need to sync your fork

beanumber commented 4 years ago

I think this Travis failure can be ignored. It doesn't seem to have anything to do with this PR. @rudeboybert

rudeboybert commented 4 years ago

Yep, you can ignore the travis failure. But the package checks say that there is a mismatch between the roxygen2 help file code and the variable names in the data frame. Also, a few remaining data wrangling clean-ups in process_data_sets_kara.R and then we'll be ready to merge

kvanallen commented 4 years ago

I combined the help files and cleaned up the data wrangling. Please let me know if more needs to be done. Thank you so much!

kvanallen commented 4 years ago

Thank you! I fixed the final changes.

rudeboybert commented 4 years ago

Congrats! Your PR is merged! you're now listed as a one of the package contributors