search

rudeboybert / fivethirtyeight

R package of data and code behind the stories and interactives at FiveThirtyEight
https://fivethirtyeight-r.netlify.app/
Other
454 stars 104 forks source link

New PR for foul_balls ds #65

Closed aballou16 closed 4 years ago

beanumber commented 4 years ago

@aballou16 you don't have to keep making new pull requests. Any commits you make will automatically be added to this one.

beanumber commented 4 years ago 
* checking for code/documentation mismatches ... WARNING

Data codoc mismatches from documentation object 'foul_balls':

Variables in data frame 'foul_balls'

  Code: camera_zone exit_velocity game_date matchup predicted_zone

        type_of_hit used_zone

  Docs: camera zone exit_velocty game_date matchup predicted zone

        type_of_hit used_zone

@aballou16 note the following WARNING on Travis. Can you add the underscores so that these match exactly?

aballou16 commented 4 years ago

@beanumber I fixed the underscores in the documentation. Should be all set.

aballou16 commented 4 years ago

@rudeboybert I believe I have fixed everything. I will also be submitting a pull request to 538 to amend those typos you noticed.

rudeboybert commented 4 years ago

Merged! You're now a package contributor: https://github.com/rudeboybert/fivethirtyeight/graphs/contributors

rudeboybert commented 4 years ago

Thanks!