search

rudeboybert / fivethirtyeight

R package of data and code behind the stories and interactives at FiveThirtyEight
https://fivethirtyeight-r.netlify.app/
Other
455 stars 107 forks source link

Adding nba_draymond #67

Closed Janebang closed 4 years ago

Janebang commented 4 years ago

Adding nba_draymond data to fivethirtyeight package

beanumber commented 4 years ago

@Janebang you need to commit the man files as well, and also add yourself to DESCRIPTION and update the NEWS.md. Please see #54 and #56 .

Janebang commented 4 years ago

I am having an error saying installing package DESCRIPTION failed for package 'fivethirtyeight'. Any ideas why?

Janebang commented 4 years ago

I figured it out!

beanumber commented 4 years ago

Travis says:

* checking Rd files ... WARNING

prepare_Rd: man/nba_draymond.Rd:24: unexpected section header '\keyword'

prepare_Rd: man/nba_draymond.Rd:25: unexpected END_OF_INPUT '

@Janebang can you please double-check your roxygen tags in R/data_jane.R?

beanumber commented 4 years ago

Travis says:

* checking for code/documentation mismatches ... WARNING

Data codoc mismatches from documentation object 'nba_draymond':

Variables in data frame 'nba_draymond'

  Code: draymond player possessions season

  Docs: DRAYMOND player posessions season

These entries have to be spelled exactly the same @Janebang .

rudeboybert commented 4 years ago

Hey @Janebang, note you don't need to delete and create a new PR when you need to make changes: just commit/push your changes, and this PR #67 will update itself. Just making sure you know this.

rudeboybert commented 4 years ago

Merged! Congrats, you're now listed as a contributor to the package!