added and cleaned nbaallelo data from 538

rudeboybert / fivethirtyeight

R package of data and code behind the stories and interactives at FiveThirtyEight

https://fivethirtyeight-r.netlify.app/

Other

455 stars 107 forks source link

added and cleaned nbaallelo data from 538 #68

Closed jkeast closed 4 years ago

beanumber commented 4 years ago

@jkeast please see #54 for instructions about adding yourself to DESCRIPTION and adding the new data set to NEWS.md.

beanumber commented 4 years ago

@jkeast I applaud your use of branches! But in this case it's hard to see what is going on because #68 , #69 , and #70 are really all part of one set of changes.

Could you close #69 and #70 and merge the two patches to master in your fork? That should bring the two patches into this pull request...

beanumber commented 4 years ago

Travis says:

* checking for missing documentation entries ... WARNING

Undocumented code objects:

  ‘nbaallelo’

Undocumented data sets:

  ‘nbaallelo’

rudeboybert commented 4 years ago

Thanks @jkeast, you are now listed as a pkg contributor: https://github.com/rudeboybert/fivethirtyeight/graphs/contributors