search

rudeboybert / fivethirtyeight

R package of data and code behind the stories and interactives at FiveThirtyEight
https://fivethirtyeight-r.netlify.app/
Other
454 stars 104 forks source link

Adds impeachment polls, second try #76

Closed fatimak98 closed 4 years ago

fatimak98 commented 4 years ago

adding impeachment polls dataset, second try after addressing some errors from first try @beanumber

beanumber commented 4 years ago

I'm confused why there are so many files in this PR. We may need @rudeboybert 's help with this...

rudeboybert commented 4 years ago

Hey @fatimak98, thanks for your PR. Unfortunately, there are many more files included in your PR than should be necessary (56 files instead of about 7 or 8). I think it will be less hassle to start over clean:

  1. Copy all files where you made substantive changes somewhere else. This way you won't lose your work: data-raw/process_data_sets_fatima.R and R/data_fatima.R.
  2. Delete your forked copy of the repo in your GitHub account, as well as the local copy of the repo on your computer
  3. Start the whole fork and clone process from scratch.
  4. Copy over your previous work in data-raw/process_data_sets_fatima.R and R/data_fatima.R
  5. Be sure to update NEWS.md and DESCRIPTION as well.
  6. Build the package
  7. "Check" the package for errors
  8. Create a new PR. The PR should involve only about 7 files, not 56

I'll close this PR so that you can start fresh. Tagging @beanumber