search

rudeboybert / fivethirtyeight

R package of data and code behind the stories and interactives at FiveThirtyEight
https://fivethirtyeight-r.netlify.app/
Other
454 stars 105 forks source link

Update to `comic_characters` vignette #86

Closed mariumtapal closed 4 years ago

mariumtapal commented 4 years ago

Hi @jonathanbouchet

In the next release of the fivethirtyeight package, we are transitioning large datasets, including comic_characters (used in your user-submitted vignette) to the fivethirtyeightdata package, where they will be available in full instead of a preview.

Since the dataset is read-in and cleaned manually (with the code provided in the help file), the vignette doesn't need to be changed, but we would like to include a message indicating the updated location of the dataset.

Please let us know if this is okay!

jonathanbouchet commented 4 years ago

sure, please make the change.

On Wed, Jul 15, 2020 at 4:25 AM Marium Tapal notifications@github.com wrote:

Hi @jonathanbouchet https://github.com/jonathanbouchet

In the next release of the fivethirtyeight package, we are transitioning large datasets, including comic_characters (used in your user-submitted vignette https://fivethirtyeight-r.netlify.app/articles/comics_gender.html) to the fivethirtyeightdata https://github.com/fivethirtyeightdata/fivethirtyeightdata package, where they will be available in full instead of a preview.

Since the dataset is read-in and cleaned manually (with the code provided in the help file), the vignette doesn't need to be changed, but we would like to include a message indicating the updated location of the dataset.

Please let us know if this is okay!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rudeboybert/fivethirtyeight/issues/86, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBFWQXCLMQIINCXSKC4TVLR3WG4LANCNFSM4O2OAFSA .