search

rudetrooper / Octoprint-Chituboard

Added basic support chituboard based printers(Elegoo Mars, Anycubic Photon, Phrozen, etc.) to octoprint.
GNU Affero General Public License v3.0
81 stars 18 forks source link

Install script defaults to the pi user which may not exist #44

Closed protoz closed 1 year ago

protoz commented 1 year ago

Last year, the Raspberry Pi Foundation no longer ships with the default user pi this has caused my pi to fail to boot after restarting when it fails to mount the disk that does not exist.

It would be nice to have a prompt to ask which user to install with and default to pi if the user does not input anything. The first reboot with the password change should only happen if you actually change the password. I end up commenting out that first block because it's not very useful.

I can open a branch to make these changes if that helps

rudetrooper commented 1 year ago

Opening a branch would be helpful, I'll try to fix the script this weekend.

protoz commented 1 year ago

Added a PR: #46

rudetrooper commented 1 year ago

It looks good, PR accepted