search

rudigiesler / mathml-to-image-service

HTTP Rest API for converting mathml to various image formats
MIT License
6 stars 9 forks source link

implement optional file size optimization #12

Closed rudigiesler closed 10 years ago

rudigiesler commented 10 years ago

https://github.com/rudigiesler/mathml-to-image-service/blob/master/mathml_to_image_service/svg_to_image.py#L47

zoidyzoidzoid commented 10 years ago

I merged #13, so you'll have to merge master back into it.

zoidyzoidzoid commented 10 years ago

What do you think about having a default quality?

rudigiesler commented 10 years ago

I think that the approach we were taking is no default values for any of the parameters, and that it should give an error if anything is missing, for people who don't read the docs?

zoidyzoidzoid commented 10 years ago

Yeah, I remember @jonathanendersby saying that.

I guess once we have to worry about backwards compatibility then when we add more things we can worry about some things having defaults.

rudigiesler commented 10 years ago

It's not being used anywhere yet, and we haven't done a version release, so I think it's okay to add these things until we do a release.

zoidyzoidzoid commented 10 years ago

Yeah, that's what I was trying to get at. Agreed. :+1: