create tests for svg_to_image

rudigiesler / mathml-to-image-service

HTTP Rest API for converting mathml to various image formats

MIT License

6 stars 9 forks source link

create tests for svg_to_image #13

Closed rudigiesler closed 10 years ago

zoidyzoidzoid commented 10 years ago

Are we gonna catch the new exceptions in the service to raise useful responses?

rudigiesler commented 10 years ago

Things like invalid SVG should never happen and indicate an internal error, so those shouldn't go through to the user. Things like Unsupported file format we probably want to give to the user.

zoidyzoidzoid commented 10 years ago

We can either check the file format in the view/route, or catch that exception and turn it into a response.

rudigiesler commented 10 years ago

Should we do that in another PR, since the goal of this PR was to create tests?

zoidyzoidzoid commented 10 years ago

Sure, sounds good to me. :+1: