allow logging of frozen strings

rudionrails / yell-adapters-syslog

Syslog adapter for Yell

MIT License

3 stars 2 forks source link

allow logging of frozen strings #1

Closed afex closed 11 years ago

afex commented 11 years ago

after integrating this gem with our sinatra apps, we had test failures related to frozen strings. specifically the "env['sinatra.error'].message" string in an "error" block

 RuntimeError:
   can't modify frozen string
 # /Users/kthornhill/.rvm/gems/ruby-1.9.2-p318/gems/yell-adapters-syslog-1.2.0/lib/yell/adapters/syslog.rb:173:in `strip!'

this PR checks the frozen state of the message and duplicates it if needed.

rudionrails commented 11 years ago

I wonder if that should be in Yell::Event directly... might be an issue for other adapters as well.