search

rudionrails / yell

Yell - Your Extensible Logging Library
MIT License
311 stars 21 forks source link

Drop native tainting feature and use an attribute #58

Closed balasankarc closed 4 years ago

balasankarc commented 4 years ago

Ruby 2.7 dropped the support of tainting, so we can't use it anymore - https://bugs.ruby-lang.org/issues/16131

Easiest fix is to use a variable for it.

Related to https://github.com/rudionrails/yell/issues/57

rudionrails commented 4 years ago

@balasankarc thanks for the detailed issue and PR!

balasankarc commented 4 years ago

Thanks @rudionrails. Also, would it be possible to tag a new release from https://github.com/rudionrails/yell/commit/e7a7498ff2ab9fb2367f80d5394583b5557caa9a so that it show up on releases page (I know you already pushed it to rubygems :) )

boegel commented 6 months ago

Seems like this is the fix for this problem that we saw with Transrate which depends on Yell

level.rb:181:in 'calculate!': undefined method 'tainted?' for an instance of Yell::Level

Why is there no Yell release yet that includes this fix?!