rudix-mac / rudix

Build system target on macOS with precompiled packages
https://rudix.org
BSD 3-Clause "New" or "Revised" License
194 stars 35 forks source link

Merged with upstream and included sort order for patches again #91

Closed paaguti closed 3 years ago

paaguti commented 5 years ago

Hi

I really think coding the patch sorting order in the files and not in Makefile is more than handy. I have included a link that explains how to fix the order in $(wildcard.

Seeing the order of the patches with the xyz-.patch file naming convention autodocuments, and should be more intuitive than having to write a hook when you have several patches to apply in order to guarantee the patch order

ruda commented 5 years ago

Hi

I really think coding the patch sorting order in the files and not in Makefile is more than handy. I have included a link that explains how to fix the order in $(wildcard.

Hello, there isn't anything disallowing you to use some numeric prefix to apply patches in order. The Rudix.mk makefile you look for patches in current directory and inside the patches/. I notice that also using .diff as a name of patch is a good thing, so I'm gonna also consider .patch and *.diff as well.

Seeing the order of the patches with the xyz-.patch file naming convention autodocuments, and should be more intuitive than having to write a hook when you have several patches to apply in order to guarantee the patch order

Documentation is lack, I don't have much to do with it now.

ruda commented 5 years ago

If you want to make a suggestion, the best way is to create a new issue for that feature, because a bunch of commits are very difficult for the maintainer to track.

paaguti commented 5 years ago

Ok, I’ll do that

Enviado desde mi iPhone

El 18 ene 2019, a las 0:48, Rudá Moura notifications@github.com escribió:

If you want to make a suggestion, the best way is to create a new issue for that feature, because a bunch of commits are very difficult for the maintainer to track.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ruda commented 5 years ago

I need to think hard about this merge request! It is very difficult to me to handle it. I usually take some parts (commits) of your work and do it manually on the master (the git cherry-pick thing). I really appreciate your work, but I could not manage it.

I'm thinking of a way to help you to collaborate and keep things easy for me.

paaguti commented 5 years ago

Never mind,

I try to keep my repo updated with yours and recommit as much as possible. I understand that there are things that may not be general interest ;-)

/PA

Enviado desde mi iPad

El 30 jun 2019, a las 1:28, Rudá Moura notifications@github.com escribió:

We need to think hardly about this merge request! It is very difficult to me to handle it. I usually take some parts (commits) of your work and do it manually on the master (this is git cherry-pick thing). I really appreciate your work, but I could not manage it.

I'm thinking of a way to help you to collaborate easily.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

paaguti commented 5 years ago

I did it again... :-) I'm using TexLive a lot and there are some utilities that depend on the libraries installed by XQuartz. I have just pushed the libs needed to compile libXext, needed by MetaFont.

Bonus: updated GNUPlot and included a small test file

PS: BIG thumbs up for the Python cleanup ;-)