rudolfochrist / interleave

Emacs minor mode to interleave notes and text books
329 stars 18 forks source link

Naming consistency; saving window config; lighter #4

Closed kaushalmodi closed 9 years ago

kaushalmodi commented 9 years ago

Hi,

The following implementation to make the interleave mode work with pdf files viewed using pdf-view did not work for me; it started throwing error backtraces.

(defun interleave-pdf-view-after-page ()
    "Go to the page's notes after the page has been changend with `pdf-tools'."
    (interleave-go-to-page-note (pdf-view-current-page)))

  (add-hook 'pdf-view-change-page-hook 'interleave-pdf-view-after-page)

So I went ahead and reverted my fork to the earlier implementation of simply redefining the interleave-- functions if pdf-view is used.

In addition, I made few house-keeping and minor feature-addition changes:

rudolfochrist commented 9 years ago

WOW! Thanks for your effort.

kaushalmodi commented 9 years ago

Thanks for accepting the pull request! :)