search

rudolfochrist / ql-https

HTTPS support for Quicklisp via curl
MIT License
21 stars 3 forks source link

Check if `curl` is installed #17

Open rudolfochrist opened 3 weeks ago

rudolfochrist commented 3 weeks ago 
          Ok, can you at least guide me as to where I have to make the change since it's your code base?

Originally posted by @daninus14 in https://github.com/rudolfochrist/ql-https/issues/9#issuecomment-2366744140

rudolfochrist commented 3 weeks ago

Since this system is absolutely useless without curl we need to check as early as possible. Best would be ql-https isn't loaded at all if curl isn't found. Perhaps the best place for this is the ASD file itself.

daninus14 commented 3 weeks ago

the asd file of quicklisp or ql-https?

rudolfochrist commented 3 weeks ago

ql-https.asd of course.

daninus14 commented 3 weeks ago

Wouldn't it be best to do a pull request to quicklisp itself with whatever changes are necessary and check there if curl is available and based on that decide what function to use? Why have a separate ql-https package at all if with this check we can actually merge the changes into quicklisp?

rudolfochrist commented 3 weeks ago

Perhaps. But why discussing changes for quicklisp here? Feel free to open as many PRs in quicklisp's repositories as you want. As long those PRs haven't been merged into quicklisp, people can use ql-https if they want.

daninus14 commented 3 weeks ago

Well, the idea I had was to try to merge your code into quicklisp since you did all the work already. Though I don't know your code base, would you not like to make a PR from here to quicklisp to have it integrated?

rudolfochrist commented 2 weeks ago

Hmmm.....,

I know the code base of ql-https but then I have to figure out the code base of quicklisp-client. Honestly, I neither have the time nor the energy for that. If you want to do this, be my guest. But please don't push me to make changes you would like to have.

If you want a secure quicklisp that not only uses SSL/TLS but also verifies signatures, have a look at ocicl/ocicl