search

rudolph-miller / jonathan

JSON encoder and decoder.
http://rudolph-miller.github.io/jonathan/overview.html
164 stars 24 forks source link

SIMPLE-VECTOR is not build-in-class on ECL #26

Closed fukamachi closed 9 years ago

fukamachi commented 9 years ago

When loading Jonathan on ECL, it raises an error at %to-json.

[package jonathan.encode].....
Condition of type: SIMPLE-ERROR
In method definition for %TO-JSON, found an invalid specializer (SIMPLE-VECTOR)

Available restarts:

1. (TRY-RECOMPILING) Recompile encode and try loading it again
2. (RETRY) Retry loading FASL for #<cl-source-file "jonathan" "src" "encode">.
3. (ACCEPT) Continue, treating loading FASL for #<cl-source-file "jonathan" "src" "encode"> as having been successful.
4. (ABORT) Give up on "jonathan"
5. (RESTART-TOPLEVEL) Go back to Top-Level REPL.

Broken at SI:BYTECODES. [Evaluation of: (QUICKLISP-CLIENT:QUICKLOAD :JONATHAN)] In: #<process TOP-LEVEL>.

https://github.com/Rudolph-Miller/jonathan/blob/master/src/encode.lisp#L229

Because SIMPLE-VECTOR is a type, not a build-in-class on ECL.

rudolph-miller commented 9 years ago

I fixed this to use vector instead of simple-vector.

fukamachi commented 9 years ago

Great. Thanks!

rudolph-miller commented 9 years ago

Thanks for your reporting! :)