rudrab / Shadow

Flat icons; Beautiful Linux
GNU General Public License v3.0
125 stars 19 forks source link

Top tab close button of temrminator special looking #118

Open MalcolmMielle opened 6 years ago

MalcolmMielle commented 6 years ago

The tab bar of terminator when I have multiple tabs as a close button that look different fro the rest. I'm not sure if this is on purpose or not :). Superb theme otherwise

screenshot from 2017-12-14 14-55-09

rudrab commented 6 years ago

I am assuming that you are using shadow-png, right? If you are in gtk-based desktop(e.g. gnome, mate etc), please use shadow-4.3.1, tagged with gnome. And if you are in kde, then can you kindly send me a full screenshot with close, minimize, maximize visible so that I can see?

MalcolmMielle commented 6 years ago

I'm on gnome and I've simply clone this repo in the .icon folder :).

Doing git checkout v3.4.1 doesn't change the icon used by terminator. i'm not sure how to get the version tagged with gnome :S

rudrab commented 6 years ago

oh...my mistake. I thought you have downloaded it from opendesktop. Just to be sure, have you run "changecolor.py" script, after placing this repo in .icon? I am asking this because I am getting terminator as intended (check the link to google photo) https://photos.app.goo.gl/l4GeHLXep4tFxD6G3 Also, since all window should have same icon for close button, can you confirm if you are getting this type of icon in other apps as well? And finally, what shell theme you are using(Adwaita)? kindly let me know so that I can check.

MalcolmMielle commented 6 years ago

I have now run the script but the result is the same :). It's also not the close button of the window that looks like this but the close button of the tab space (when one does Ctrl-Alt-T in terminator). The top close button looks perfectly normal :). The default shell theme is Adwaita and I haven't seen this icon anywhere else for now

screenshot from 2017-12-19 02-39-36

rudrab commented 6 years ago

First, you are running a old version of the icons. Please clone it as: git clone https://github.com/rudrab/Shadow.git in your ~/.icons folder, and then do: python3 changecolor.py. You will get option to choose your de and color:

 python3 changecolor.py 
Carefulness assumed.
i.e. You may face some weird icon if you choose MATE
when you don't have MATE icon or MINT installed!
Choose your desktop environments
1: Gnome-3
2: Mate
3: Pantheon
4: Unity
Enter 1/2/3 etc to choose your de:1
You have chosen GNOME Desktop Environment
Now choose your favourite color scheme
1:  Emerald  
2:  Garnet   
3:   Ruby    
4: Sapphire  
5: Torquiose 
9:Square
Enter 1/2/3 etc to choose your color scheme:3
RUBY scheme will be applied
places_ruby
./places_ruby/system-file-manager.svg
gnome
/tmp/Shadow/scalable/places_ruby

Please, kindly let me know if this git version solves your problem.