CajunAvenger
commented
6 months ago - Updated the jsons and index
- Readded set.magicCardsInfoCode, which was what caused the set codes to downcase. fixed the legality files to reflect this.
- Added set.release_number and set.type
- Fixed several issues with reminder text, designers, and inconsistent string vs integer pts that were causing rake warnings
- fixed missing changelogs and broken rulings
- Adjusted split card numbers
- Improved Adventure support
- "adventure" is now a functional layout
- patch_secondary now checks the card.side parameter to determine secondary side, making it work for Adventures and modal DFCs
- added CardPrinting::image_slug which gives split cards and adventure cards their proper image while still being a/b numbered.
- Adventures/Tales are now searchable and don't overrule their front face
- Improved set priority
- Set priority now uses set.type, so the list of masters sets don't need to be continually updated
- Set priority now uses set.release_number, so rake doesn't freak out over every reprint
- Set priority now puts in-set promos behind in-set normal cards to be inline with promo sets being put lower.
- Champions and Designers
- Champion and Designer have been moved to CardPrinting instead of Card
- CardPrinting.champion and CardPrinting.designer weren't working, and i could not work out why, Card not having those, using attr_reader, and defining it manually all did nothing
- added CardPrinting::prints_champion and CardPrinting::prints_designer, which work fine though
- cards can now support multiple champions or multiple designers across their printings. the Card class no longer has these, but an array of them could be generated after printings are.
- Mana Updates
- Added the mana changes from the Revolution PR, adding mana symbols for Moresso and Mystery of the Crashed Craft
- Other
- Fixed the bugged text on typed trilands