search

rueckstiess / mtools

A collection of scripts to set up MongoDB test environments and parse and visualize MongoDB log files.
Apache License 2.0
1.88k stars 397 forks source link

Fix handling of directConnection default #875

Closed blink1073 closed 2 years ago

blink1073 commented 2 years ago

Description of changes

Only add directConnection=True when not connecting to a replica set.

Testing

launch init --replicaset --name repl0 --nodes 3 --port 27017 --hostname localhost

O/S testing: O/S Version(s)
Linux
macOS 12.4
Windows
blink1073 commented 2 years ago

Alternative to #853

blink1073 commented 2 years ago

Depends on https://github.com/rueckstiess/mtools/pull/876 for CI fix.

p-mongo commented 2 years ago

In https://github.com/rueckstiess/mtools/issues/859#issuecomment-1136026968 I enumerate the locations where direct connection is needed. We use mtools to launch all possible configurations so this should be the complete list.

stennie commented 2 years ago

Fixed by way of 1b9905f