search

ruediger / VobSub2SRT

Converts VobSub subtitles (.idx/.srt format) into .srt subtitles.
GNU General Public License v3.0
294 stars 67 forks source link

pull request for the brew formula that fixes documentation error #22

Closed subpop closed 11 years ago

subpop commented 11 years ago

just adds make documentation to the build line.

ruediger commented 11 years ago

I guess the "cd build" isn't necessary here. Could you try it with

system "make install"

instead? (I have no OSX currently available to test it myself)

ruediger commented 11 years ago

d2a5d43 should fix the issue in any case. I guess the documentation should always be build when called with make (all). But it would still be better if the brew script wouldn't use the CMake generated Makefile directly and rather the provided wrapper in the project root.

Thanks so far for your help!

subpop commented 11 years ago

c1bfcd2 I switched the build to use the root Makefile and call just 'make install'. Seems to work fine here.

ruediger commented 11 years ago

Thanks! How should I attribute you in the readme? Simply as subpop or with your real name?

subpop commented 11 years ago

Don't worry about attribution. It was so minor a change, it's no big deal.