search

ruediger / VobSub2SRT

Converts VobSub subtitles (.idx/.srt format) into .srt subtitles.
GNU General Public License v3.0
294 stars 66 forks source link

Fix for #29: output subtitled with overlapping errors #32

Closed dex6 closed 10 years ago

dex6 commented 10 years ago

It looks like spudec can return end_pts=UINT_MAX, which apparently means 'display this until the next subtitle'. Added a caching layer; first all converted subtitles are stored in a vector and then written to the file with end_pts value fixed if needed.

dex6 commented 10 years ago

Please review before merging and feel free to change anything in this patch - I haven't touched C++ for a while until now.

Also it's my first thing on github, so please forgive any mistakes...

ruediger commented 10 years ago

Sorry I haven't replied so far. I have looked into it and consider changing it a bit. I'm not happy with the idea of having two iterations. I'm thinking about changing it somehow to one iteration. But thank you very much for finding the issue and creating a patch.

ruediger commented 10 years ago

I guess two loops are a bit easier to handle. I finally merged your patch and updated it slightly.

Thanks for your contribution! I have added you to the list of contributors.