search

ruediger / VobSub2SRT

Converts VobSub subtitles (.idx/.srt format) into .srt subtitles.
GNU General Public License v3.0
294 stars 66 forks source link

Y-threshold option converts all palette entries below it to black. #43

Closed justyn closed 9 years ago

justyn commented 9 years ago

Adds new argument to command line but doesn't change default behaviour.

It sends the Y-threshold as an extra argument to the mplayer-related functions. If you'd prefer it be implemented differently let me know.

justyn commented 9 years ago

On the box set of DVDs I'm testing it on, using a y-threshold value of 200 causes a huge improvement in accuracy.

ruediger commented 9 years ago

Looks good except for the extra conversion step. I don't really have time to test it now though. It will be around 3 weeks I guess. Please just ping me if I haven't replied by then.

justyn commented 9 years ago

Good point, I've removed the extra step.

justyn commented 9 years ago

Ping, as requested. Happy new year!

ruediger commented 9 years ago

Sorry for the long delay. Looks good so far, except for two minor things:

  1. Please declare spudec_yuv_under_threshold as static (see the warning)
  2. You've left in the #include <cstdlib> statement. But cstdlib is not needed.
  3. Please rebase all commits into a single one. (Either in this PR or create a new one).

Thanks so far!

justyn commented 9 years ago

Ok should all be done in the new rebased commit.

ruediger commented 9 years ago

Thanks!