ruediger / VobSub2SRT

Converts VobSub subtitles (.idx/.srt format) into .srt subtitles.
GNU General Public License v3.0
293 stars 65 forks source link

HomeBrew formula broken #63

Closed CamJN closed 6 years ago

CamJN commented 6 years ago
brew install --HEAD https://raw.githubusercontent.com/ruediger/VobSub2SRT/master/packaging/vobsub2srt.rb
######################################################################## 100.0%
==> Installing vobsub2srt 
==> Cloning git://github.com/ruediger/VobSub2SRT.git
Updating /Users/camdennarzt/Library/Caches/Homebrew/vobsub2srt--git
==> Checking out branch master
==> ./configure ["-DCMAKE_C_FLAGS_RELEASE=-DNDEBUG", "-DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG", "-DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/vobsub2srt/HEAD-d4c34ca", "-DCMAKE_BUILD_TYPE=Release", "-DCMAKE_FIND_FRAMEWORK=LAST", "-DCMAKE_VERBOSE_MAKEFILE=ON", "-Wno-dev"]
==> make install
Error: Empty installation
HOMEBREW_VERSION: 1.3.5-4-g56458f0
ORIGIN: https://github.com/Homebrew/brew
HEAD: 56458f03fcc68ef6d8ee3ee4a7c1d16021aa5800
Last commit: 22 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: be58c3e7adb0801b0e0259d6120282ab5e3d35f3
Core tap last commit: 2 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_REPOSITORY: /usr/local/Homebrew
HOMEBREW_CELLAR: /usr/local/Cellar
HOMEBREW_BOTTLE_DOMAIN: https://homebrew.bintray.com
CPU: octa-core 64-bit haswell
Homebrew Ruby: 2.3.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby
Clang: 9.0 build 900
Git: 2.14.2 => /usr/local/bin/git
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /Users/camdennarzt/.rbenv/shims/ruby => /Users/camdennarzt/.rbenv/versions/2.3.5/bin/ruby
Java: 9
macOS: 10.13-x86_64
Xcode: 9.0
CLT: 9.0.0.0.1.1504363082
X11: N/A
CamJN commented 6 years ago

This works:

# Homebrew Formula for VobSub2SRT
# Usage: brew install https://github.com/ruediger/VobSub2SRT/raw/master/vobsub2srt.rb

require 'formula'

class Vobsub2srt < Formula
  head 'git://github.com/ruediger/VobSub2SRT.git', :using => :git
  homepage 'https://github.com/ruediger/VobSub2SRT'

  depends_on 'cmake'
  depends_on 'tesseract'
  depends_on 'ffmpeg'

  def install
    mkdir "build" do
      system "cmake", "..", *std_cmake_args
      system "make", "install"
    end
  end
end
ruediger commented 6 years ago

Hi, could you make a PR to update the formula please.

CamJN commented 6 years ago

https://github.com/ruediger/VobSub2SRT/pull/64

NicholasMata commented 6 years ago

If you do brew link vobsub2srt after running brew install --HEAD https://github.com/ruediger/VobSub2SRT/raw/master/packaging/vobsub2srt.rb command vobsub2srt should work.

CamJN commented 6 years ago

It would still be nice to avoid the errors all-together.

ruediger commented 6 years ago

64 merged. Thanks CamJN!