search

ruediger / VobSub2SRT

Converts VobSub subtitles (.idx/.srt format) into .srt subtitles.
GNU General Public License v3.0
293 stars 65 forks source link

Fix compile with gcc7 and tesseract 4 #72

Open bit opened 5 years ago

sl1pkn07 commented 5 years ago

should be in CXX, not in C

bit commented 5 years ago

You want to remove set(CMAKE_C_FLAGS "-std=gnu99") and add -std to CXX flags?

sl1pkn07 commented 5 years ago

set(CMAKE_CXX_FLAGS "-ansi -pedantic -Wall -Wextra -Wno-long-long -std=gnu++11")

instead of

set(CMAKE_C_FLAGS "-std=gnu++11")

bit commented 5 years ago

any chance to merge this?

Chris00 commented 4 years ago

The alternative set(CMAKE_CXX_STANDARD 11) — proposed in issue https://github.com/ruediger/VobSub2SRT/issues/73 — works too and is maybe more elegant.

Chris00 commented 4 years ago

I use gcc (Debian 9.2.1-25) 9.2.1 20200123 and this patch (or the alternative) is still required.

glensc commented 4 years ago

I can confirm this fixed for me build on Linux

glensc commented 4 years ago

This PR needed for docker build too: https://github.com/ruediger/VobSub2SRT/pull/77