Animated Memory matching game is unsolvable

ruffle-rs / ruffle

A Flash Player emulator written in Rust

https://ruffle.rs

Other

15.45k stars 800 forks source link

Animated Memory matching game is unsolvable #11623

Open pgnj99 opened 1 year ago

pgnj99 commented 1 year ago

Describe the bug

This is a simple memory matching game, but on Ruffle there's no more matches after getting down to about 8 or 10 tiles, rendering the game unsolvable.

Source websites: https://web.archive.org/web/20220718094520/http://www.zefrank.com/memory/index.html https://ooooooooo.ooo/static/?7fc2658a-8537-41b5-ba3e-bc7d998d9945

https://github.com/ruffle-rs/ruffle/assets/57976747/bb68a989-c3e2-45b7-b90b-abd475c9187b

Expected behavior

There are 36 tiles and each one is supposed to have a match.

Affected platform

Desktop app

Operating system

Windows 10

Browser

No response

Additional information

No response

Lord-McSweeney commented 1 year ago

(I got to 12 tiles before running out of matches, so it clearly isn't very consistent).

Toad06 commented 1 year ago

Interesting (and unfortunate) issue.

This game is a SWFv4 file that defines a variable named string. This variable is not initialized and is first used as follows: string = string add chr(count + "96");

In Flash, string add does "" add, as undefined is coerced to the empty string in SWFv6 and below.
In Ruffle, string add does "[type Function]" add, as this coerces the String function (case is insensitive in SWFv6 and below).

Renaming this variable to anything else prevents the issue from happening.

Other related issues and PRs: #6235, #7004