ruffle-rs / ruffle

A Flash Player emulator written in Rust
https://ruffle.rs
Other
15.76k stars 821 forks source link

Train Mania: Jittery graphics #12791

Open n0samu opened 1 year ago

n0samu commented 1 year ago

Describe the bug

Link to SWF: http://i.notdoppler.com/files/trainmania.swf

In Ruffle build 2023-07-22 and later, some graphics in Train Mania have become jittery. You can see it in the track in the intro, the Continue button, the NextPlay logo, and especially the Train Mania logo on the main menu.

https://github.com/ruffle-rs/ruffle/assets/71368227/11017086-e6f8-4e07-8f2e-f870ff67ead9

Expected behavior

Here is what the game looks like in Flash Player:

https://github.com/ruffle-rs/ruffle/assets/71368227/69e39b75-4889-44d2-957f-fed1f5be2715

And here is what it looked like in Ruffle nightly 2023-07-21:

https://github.com/ruffle-rs/ruffle/assets/71368227/9cb5afc1-f401-4c35-978d-268267439279

Compared to Flash Player, in Ruffle the mentioned graphics seem to render a bit inconsistently over time. But at least they weren't moving/jittering.

Affected platform

Desktop app

Operating system

Windows 10

Browser

No response

Additional information

This change was caused by #11916.

Note that the game does not explicitly use pixel snapping anywhere.

n0samu commented 1 year ago

The difference is actually more noticeable on the screen where you select a train:

2023-07-21:

https://github.com/ruffle-rs/ruffle/assets/71368227/36de2a7c-9b26-4009-a3e0-ec2134e2f972

2023-07-22:

https://github.com/ruffle-rs/ruffle/assets/71368227/e30d02d3-1f36-42bd-a355-ebce714c49f5