Ultrasounds: Gallery Pictures

[sombraguerrero]

Describe the bug

Now that we have mouse picking working on edittexts sufficiently that the gallery links in Ultrasounds work, this exposes the next issue with that SWF where images that are in the expected path structure (see the attached zip) are not being rendered. I can see in the browser dev console from my test bed that the links are triggering, and the images are loading in. I suspect we're not handling the coordinate object passed into loadMovie. ultrasounds.zip Original site: https://www.ultrasounds.com

Expected behavior

Valid jpegs should render when loaded into the browser via the links.

Affected platform

Self-hosted version

Operating system

Windows 11

Browser

Chromium Edge

Additional information

8/27/23 nightly

[n0samu]

Found it! 😆

These lines of code from the forGallery function position the clip in this offscreen location:

    forGpic._x = 670;
    forGpic._y = 18;

The movie uses an onClipEvent(data) function to reposition the clip in the correct location:

onClipEvent(data){
    this._x = -84;
    this._y = 18;
    this._x -= this._width / 2;
    this._y -= this._height / 2;
}

Unfortunately, it seems like Ruffle does not fire onClipEvent(data) / onData for image loads.

[sombraguerrero]

Clever. Silly, but clever.

[n0samu]

It seems like we aren't firing the event for loadMovie at all. Here is a small demonstration: OnClipEventDataTest.zip

[sombraguerrero]

That was my suspicion. I think loadMovie has several overloads we just don't have accounted for.

[n0samu]

Related to #7301.