search

ruffle-rs / ruffle

A Flash Player emulator written in Rust
https://ruffle.rs
Other
15.4k stars 795 forks source link

Videos on https://www.slaveryinnewyork.org are not starting #13688

Open torokati44 opened 10 months ago

torokati44 commented 10 months ago

Describe the bug

The videos on the Visitor Responses section don't start, such as this one: https://www.slaveryinnewyork.org/gallery_2_responses.htm

All of the necessary files are thankfully there: https://www.slaveryinnewyork.org/flash/gallery2.swf https://www.slaveryinnewyork.org/flash/SkinUnderPlaySeekStop.swf https://www.slaveryinnewyork.org/flash/Gallery2Responses2.flv

Source: https://news.ycombinator.com/item?id=37981663

Expected behavior

The videos start playing, probably with a little video player interface, judging by the associated miscellaneous content.

Affected platform

Browser extension

kmeisthax commented 10 months ago

The videos do not play because the video player component expects scale9Grid to be populated with data from DefineScalingGrid tags in SkinUnderPlaySeekStop.swf. There's no flashlog error because the exception is caught and broadcast as an event that isn't handled elsewhere.

Even if I manually change our existing scale9Grid stub to return fresh rectangles, the video player still has layout problems. I suspect this is relying on the data in the skin SWF's scaling grid tags, so #10611 should fix the video player, but I haven't tested that yet.

n0samu commented 9 months ago

The audio from the videos plays now, and the controls are functional, but the video itself is not visible.