Placeholder text in TextField not treated as such | TextField not appearing within Sprite

React1-X commented 6 months ago

Describe the bug

The provided screenshot displays the issues with each text (compared to the Adobe Flash Player).

Placeholder text is not treated as such in the TextField. I believe this may have something to do with the event listener FocusEvent.FOCUS_IN as the code replaces the content of the TextField with an empty string when focused. Similar with FocusEvent.FOCUS_OUT, however, this behavior is not replicated on Ruffle. It seems to not detect the correct color coding for the text either.
The text is not displayed correctly in the button which is a Sprite class with a given width and height.

Expected behavior

Correctly display 'placeholder' text content in a TextField, treating it as a placeholder.
Correctly display texts within Sprite containers.

Content Location

You can find the SWF binary (latest) on our GitHub releases page.

Location of the code can be found in AuthForm.as. Notable text to search for here would be: placeholder createButton()

Affected platform

Desktop app

Operating system

Windows 10

Browser

No response

Additional information

No response

n0samu commented 6 months ago

This will hopefully be helped by #14723

React1-X commented 6 months ago

This will hopefully be helped by #14723

@n0samu @evilpie this issue is fixed thank you!

I just wanted to point out a few additional issues with it as seen in the video. Please let me know if I should create this as a separate issue.

https://github.com/ruffle-rs/ruffle/assets/157532981/40676634-8b60-4a98-a05f-f4f8c338de57

kjarosh commented 1 month ago

https://github.com/ruffle-rs/ruffle/pull/16581 should fix placeholders not appearing again, however I wasn't able to test this, as the original link to the SWF is broken, and other releases do not work at all for me.

ruffle-rs / ruffle