ruffle-rs / ruffle

A Flash Player emulator written in Rust
https://ruffle.rs
Other
15.76k stars 818 forks source link

Outpost Haven - text and performance issues #15058

Open Kz-92 opened 9 months ago

Kz-92 commented 9 months ago

Describe the bug

now that the game can start up (https://github.com/ruffle-rs/ruffle/issues/11835) , the intro text does not appear, it is completely empty. clicking once usually skips the scrolling and makes all text appear, clicking again starts the game. with ruffle, clicking just starts the game, so the text may not even exist to be skipped. (all level's intro text are similarly gone)

additionally, the game is slower with Ruffle.

flash

https://github.com/ruffle-rs/ruffle/assets/103858019/550e276c-f765-48dd-a690-f5de2387eb7d

Ruffle

https://github.com/ruffle-rs/ruffle/assets/103858019/db82bdd1-8496-45d4-ac81-078ef9a697f2

Expected behavior

the intro text should appear, the game should run better

Content Location

attached.

Affected platform

Desktop app

Operating system

windows 10

Browser

No response

Additional information

586969_Outpost-1.4-fixed.zip

kjarosh commented 1 month ago

The into text works now correctly, regarding the performance, I haven't noticed that this game runs particularly slower than others.

Kz-92 commented 1 month ago

agreed, the intro text has been fixed for some time now! last time I tested the performance wasn't great, but I will retest after some hours

overall, ruffle is very compatable here now, which is wonderful

Kz-92 commented 1 month ago

upon testing, I've found the intro text isn't as accurate as I had thought. if you let the text scroll, you can see the spacing is off, causing the last line to be cut off. the text also seems to be a bit blurry at the size it opens with by default, and is corrected on scaling, on ruffle

as for the performance, ruffle does seem to be slower than flash, by my eye but it seems to vary enough that it should be good to call ok

flash left, ruffle right https://github.com/user-attachments/assets/bca91cb7-4d30-4cb0-a4de-546e5f329042

here's a better picture of the blurry part, as the video is compressed (ruffle is on the left, this time) Image

if you skip the intro text, it shows up spaced more properly

not sure why the video is not embedding... another quirk of new github updates perhaps...

kjarosh commented 2 weeks ago

Regarding the poor text quality: it's due to quality being set to low. It seems that in Flash, the quality does not affect the text at all, no idea why. Maybe it's device text, but that seems unlikely.

The weird text spacing is caused by additional newlines being inserted in the text. That's probably an issue in HTML parsing or some other text processing code.

Edit: when you skip displaying text character-by-character, there are no additional newlines. I'm pretty sure Ruffle adds somewhere a spurious newline when SWF updates the text.