ruffle-rs / ruffle

A Flash Player emulator written in Rust
https://ruffle.rs
Other
15.39k stars 795 forks source link

Eugenics Archive - Remaining issues after Flash Remoting support #16356

Open danielhjacobs opened 3 months ago

danielhjacobs commented 3 months ago

Describe the bug

The images do not appear.

Screenshot from 2024-05-17 09-25-50

Additionally, when searching, no search results numbers show even when there are results:

Screenshot from 2024-05-17 09-30-21

Screenshot from 2024-05-17 09-35-11

A direct link to a search result does not load (for example, http://www.eugenicsarchive.org/html/eugenics/index2.html?tag=735):

Screenshot from 2024-05-17 10-16-23

Expected behavior

Clickable images should load under the list of image results:

Screenshot from 2024-05-17 09-27-10

The search for "id735" should say "Your search for "id735" returned 1 results." instead of "Your search for "id735" returned results.", the number "1" should appear in the parentheses next to both "Race Mixing and Marriage Laws" and "Hereditary Disorders":

Screenshot from 2024-05-17 09-36-44

Clicking either result after the search should load the image:

Screenshot from 2024-05-17 09-37-08

A direct link to a search result should load (for example, http://www.eugenicsarchive.org/html/eugenics/index2.html?tag=735):

Screenshot from 2024-05-17 10-18-44

Content Location

http://www.eugenicsarchive.org/eugenics/list2.pl

Affected platform

Self-hosted version

Operating system

Fedora Linux 39

Browser

Mozilla Firefox 126

Additional information

No response

danielhjacobs commented 3 months ago

Copied the requests on http://www.eugenicsarchive.org/eugenics/list2.pl to http://www.eugenicsarchive.org/amfbrowser as cURL in both Firefox with Ruffle and Pale Moon with Flash after choosing Agricultural Genetics:

Raw data in Flash: \x00\x00\x00\x01\x00\x10amf_server_debug\x01\x00\x00\x00p\x10\x00\x0eNetDebugConfig\x00\ncoldfusion\x01\x01\x00\namfheaders\x01\x00\x00\x03amf\x01\x00\x00\x0bhttpheaders\x01\x00\x00\x09recordset\x01\x01\x00\x05error\x01\x01\x00\x05trace\x01\x01\x00\x07m_debug\x01\x01\x00\x00\x09\x00\x01\x00\x13AMFApp.getResultSet\x00\x02/4\x00\x00\x00M\n\x00\x00\x00\x01\x03\x00\x03uri\x02\x00\x19amfbrowser/flash/theme/28\x00\x0bsub_to_call\x02\x00\x13getResultSet_Result\x00\x00\x09

Raw data in Ruffle: \x00\x00\x00\x01\x00\x10amf_server_debug\x01\x00\x00\x00`\x03\x00\ncoldfusion\x01\x01\x00\namfheaders\x01\x00\x00\x03amf\x01\x00\x00\x0bhttpheaders\x01\x00\x00\x09recordset\x01\x01\x00\x05error\x01\x01\x00\x05trace\x01\x01\x00\x07m_debug\x01\x01\x00\x00\x09\x00\x01\x00\x13AMFApp.getResultSet\x00\x02/1\x00\x00\x00M\n\x00\x00\x00\x01\x03\x00\x03uri\x02\x00\x19amfbrowser/flash/theme/28\x00\x0bsub_to_call\x02\x00\x13getResultSet_Result\x00\x00\x09

Response with Ruffle (attached message): ruffle_message.txt Response with Flash (attached message): flash_message.txt The encoding of the data may be the issue, meaning this may be an AMF0 issue or an issue of a misuse of AMF0 by NetConnection. However, unlike #16381, the response is nearly identical, with a minor two character difference between the Flash and Ruffle responses. But this difference may be enough to change the output.

evilpie commented 2 months ago

In flash the header is a typed object called "NetDebugConfig".