search

ruffle-rs / ruffle

A Flash Player emulator written in Rust
https://ruffle.rs
Other
15.07k stars 778 forks source link

Regression in FlxSpriteFilters demo #16983

Open SN902 opened 3 days ago

SN902 commented 3 days ago

Describe the bug

Glow filter is now broken

image

Last stable build Nightly 2024-02-01 Broken Nightly 2024-02-02

Expected behavior

Everything should work correctly

Content Location

FlxSpriteFilters.zip

Affected platform

Desktop app

Operating system

Windows 10 x64

Browser

Firefox Nightly

Additional information

No response

torokati44 commented 3 days ago

Regressed by https://github.com/ruffle-rs/ruffle/commit/fb8f3301b6a9cc9ffbefebf1ef3a6cc9a9a3a5dc, which was part of https://github.com/ruffle-rs/ruffle/pull/15032 (@Dinnerbone).

torokati44 commented 3 days ago

How is this not covered by regression tests?! :scream:

waspennator commented 3 days ago

Similar problem as #16670?

SN902 commented 3 days ago

Same problem as #16670?

It looks like the same problem, we need to check later

waspennator commented 3 days ago

I also forgot to mention, but I have a feeling #15146 was also broken by the "wgpu: Don't submit for every single BitmapData.draw()" too