search

ruffle-rs / ruffle

A Flash Player emulator written in Rust
https://ruffle.rs
Other
15.78k stars 822 forks source link

Broken water ripple effect in Castaway intro #17226

Open britt-j opened 4 months ago

britt-j commented 4 months ago

Describe the bug

https://github.com/user-attachments/assets/f8dfc420-91fb-4580-9dd2-b9f14db915a3

Expected behavior

https://github.com/user-attachments/assets/e564773d-9ad4-4c59-beef-b44151a50108

Content Location

https://ooooooooo.ooo/static/?5bbf50d8-6915-4541-b593-b79405a676b1

Affected platform

Desktop app

Operating system

WIndows 10

Browser

No response

Additional information

No response

torokati44 commented 4 months ago

I checked whether this is also regressed by https://github.com/ruffle-rs/ruffle/pull/15032, but it does not seem to be the case.

kjarosh commented 4 months ago

The logic for this effect is present in frame 1 in net.flashfilter.as3.effects.E01_raindrop (especially its render method).

britt-j commented 2 months ago

Pretty sure the effect is broken because ConvolutionFilter isn't supported yet from what I can tell https://github.com/ruffle-rs/ruffle/issues/15