search

ruffle-rs / ruffle

A Flash Player emulator written in Rust
https://ruffle.rs
Other
15.61k stars 809 forks source link

Change default value for "Open Links" on the desktop app to "Ask" #17432

Open Tiagoquix opened 2 months ago

Tiagoquix commented 2 months ago

Hello there.

Currently, "Open Links" on desktop has "Allow" as the default value. I want to suggest to change it to "Ask" for two reasons:

  1. Security: you maybe wouldn't want to accesss a random link from 10 years ago and expose your IP address and other info to that website.
  2. Annoyance: sometimes I click on Flash elements that I have no idea that they are links. A confirmation in this case would be nice.

Also, "Open Links" option does not follow the pattern of having a checkbox to be able to modify the default value. image

Not sure if making "Upgrade HTTP to HTTPS" enabled by default would be a good idea, but since Ruffle runs 100% locally on the Desktop (AFAIK) then it wouldn't be necessary, but would be cool nonetheless.

For the "Open Links" request, I believe changing "allow" to "ask" here would be sufficient.

Thanks in advance for your attention.

Korne127 commented 1 month ago

When I introduced that feature (in #10625), there was a discussion on which value to use as the default The consensus in the end was that it's okay to change it to Ask, but that we should then add a "Save this preference" checkbox so users don't get the prompt each time. I planned on doing that, but other things got in the way and then I forgot. That was mostly about the web version though, but I think we should keep it consistent, and if we resolve this, change the option and add such a checkbox in both desktop and web.

Tiagoquix commented 1 month ago

What could be done is do what I said (change it to "Ask" by default and add a checkbox to be consistent), and then add a new preference to control the default state of that setting to Ruffle user preferences (which get saved to ~/.config/ruffle/preferences.toml).