search

ruffle-rs / ruffle

A Flash Player emulator written in Rust
https://ruffle.rs
Other
15.61k stars 809 forks source link

Multiple Bugs on https://armorgames.com/play/5003/arcuz #3295

Open Bimbelimbim opened 3 years ago

Bimbelimbim commented 3 years ago
  1. Ingame item descriptions are in a wrong position. Distored_Item Description
  2. Enemies do not have their correct sprites. Their sprits should change with their level, but they do not. Level_1_ _Level_5_Slimes_on_Ruffle a group of slimes on ruffle. green_Level_1_ _yellow_Level_5_Slimes_on_Flash same group of slimes on the original game. This bug also applies for wolves, and probably for all other enemies in the game as well.
  3. Ruffle starts to lag extremely a few seconds after a skill is used, i only tested this with Hurricane, because without skills the game is not appealing to play, i did not progress to futher skills to test. Save and quitting the game (ingame menu) solves this, but that isnt a working solution of course. Hurricane_Skill
  4. None of the bugs, that were in the original game are emulated correctly, as far as i could test it, but that is actually a good thing.
adrian17 commented 3 years ago

Issue (1) was fixed with https://github.com/ruffle-rs/ruffle/pull/3163 . There are still minor margin-related issues that cause text to be just slightly cut off.

Not sure about issue (2), might be related to not-yet-implemented bitmap stuff.

Issue (3) was significantly improved with recent optimizations, but the major increasing-over-time lag still remains. I found out it's the same core issue as https://github.com/ruffle-rs/ruffle/issues/993#issuecomment-675182938 - the game creates and destroys shadows that are stored in a layerArr array. After the shadow is destroyed with removeMovieClip, normally it'd be removed from the list in refreshLayerArray, but the issue causes the script to not realize the movie clip is dead, so it remains in the list. This list is regularly sorted with a bubble sort, which means the sorting time increases quadratically over time :(

Bimbelimbim commented 3 years ago

Ive found an other problem: When I hit an enemy, this causes his health bar to be displayed till he either dies, or i stop hitting him for a few seconds. Thats how its supposed to work and how it does work, EXCEPT it only displays the health bar once the first time i attack each enemy. If i retreat and then start attacking again the health bar doesnt show.

The recent ruffle updates have now also altered Issue (4), all glitches work just like in the original, except for a small visual difference with item duping.

Bimbelimbim commented 3 years ago

Ive recently heared a few reports from others, that certain quests are incompleteable, a main quest among them, leaving the game impossible to complete. I concerns the "flickering iron ore" side quest and the "save anna" main quest.

Bimbelimbim commented 3 years ago

Ive made a savefile to doublecheck the 2 quests, they are indeed bugged. Ive recorded that. as well as all other bugs i found, including, but not limited to the aforementioned and uploaded it to my youtube: https://youtu.be/CWqR6aKu_uw I can share the savefile for testing with any developer interested, contact me on Discord.

adrian17 commented 3 years ago

Just from watching, I'd guess that most of these (including quest locks) are related to the "ghost removed movieclips" FP behavior we're missing, same as above.

Bimbelimbim commented 1 year ago

18 month later its about time for a little update on the game. During this time I've learned a lot about the games code. The ColorMatrixFilter that the games uses to recolor enemies based on their level havent been implemented into ruffle yet, but Dinnerbone recently told me on Discord that he was working on it, which means that issue will soon be fixed. The original glitches of the game have been correctly operational for quite some time and the item descriptions have also been fixed since I last commented here. This only leaves the "ghost removed movie" clip issue, which as has been shown in the video and explained here, causes a variety of errors ingame, including rendering it incompleteable.

HaimZik commented 1 year ago

The game is still slowed down after using skill multiple times. ColorMatrixFilter is unimplemented. The treasure chests collider still remain after the chest disappear.

Bimbelimbim commented 1 year ago

Nosamu asked me to test a new ruffle version with a supposed fix on the removed movieclips issue. After all full playthrough of the game, I can say that all errors in the game known to be related to this prior have disappeared. I did however noticed new errors, which were not there in prior versions of ruffle. To simplify matters, I'll count all problems new and old, that are still present.

  1. Old: The colormatrix filters for enemies are still not correctly applied.
  2. Old: Some enemies are supposed to be partially translucent. Ruffle does not do this.
  3. Old: Of the 2 methods of duping in the original game only 1 is correctly emulated (albeit with a visual glitch), the other one does not work. The working method has been tested before with the same result, the dysfunctional method was only recently discovered in the original game and was therefor not tested with ruffle before now.
  4. Old: Some item descriptions are not properly displayed.
  5. New: Skills-Icons do not properly snap to the frame of the skill-quickslots.
  6. New: Reequiping skills will cause glitched out cooldown displays. (the original game does that too, but the way the cooldowns are missdisplayed is distinctly different.) This glitch is only visual and all skills (or rather those I used for the playthrough) working correctly.

For more information contact me on Discord.

n0samu commented 1 year ago

The skill icon snapping issue is a regression caused by #7624.

Bimbelimbim commented 10 months ago

As of ruffle version nightly 2023_11_26 only two minor issues remain in this game:

The typesetting of item descriptions ingame is left aligned in ruffle, when it is supposed to be centered.

Item Duping (an original bug of this game) has a visual glitch with one method and other an method just does not work at all.

Both of these issue are minor details and do not affect gameplay mostly. Both are also present in Arcuz 2, which is unsurprising as both games share the greater part of their code.