mh's Visualizer - Screen clipped in awkward way

ruffle-rs / ruffle

A Flash Player emulator written in Rust

https://ruffle.rs

Other

15.62k stars 809 forks source link

mh's Visualizer - Screen clipped in awkward way #5220

Open firoball opened 3 years ago

firoball commented 3 years ago

Describe the bug Screen appears to be clipped in an awkward way. grafik

Expected behavior

Screen fully visible

Is the problem with the Ruffle desktop app, extension, or self-hosted version? What platform are you using?

Ruffle Web Demo 2021-09-04 in Firefox 91.0.2

SWF Link: http://visualizer.theopensourcelock.org/ Source Repo: https://github.com/mh-/AxisVisualizer

firoball commented 3 years ago

Could this code section possibly be the culprit? // Set the stage // Stage.scaleMode = "noscale"; Stage.scaleMode = "showAll"; Stage.align = "CC";

Toad06 commented 2 years ago

The issue is that Ruffle maintains the aspect ratio of the file (300x400) in the web demo and the extension (when opening an SWF in a tab) because it always sets the letterbox option to on. We need to provide a way to change this default behavior.

firoball commented 2 years ago

This is fixed in latest nightly, probably resolved long before.

Toad06 commented 2 years ago

Not really - there's a regression that affects the current builds when applying the configuration (it is not applied at all in fact, so the letterbox option is not set to on). The file will no longer be displayed correctly when #8093 is merged.

firoball commented 2 years ago

Reopening due to comment above.