Flight: Game randomly jumps around screens

[waspennator]

Describe the bug

FlightKong.zip Flight seems like it could be playable, but there's a major issue where not only does the armor games logo sound keep playing every couple of seconds, but every time it does, it randomly jumps to a different part of the game. The first time on the title screen it will jump to the intro cutscene, then it will jump to the gameplay, then it will jump right back to the preloader again. ruffle.rs-1678459607723.log

Expected behavior

The game shouldn't be jumping around screens every time the armor game logo plays (And that logo shouldn't be playing every couple of seconds)

Affected platform

Browser's extension

Operating system

Windows 11

Browser

Edge 110

Additional information

No response

[Lord-McSweeney]

TLF text and XML.settings seem to be the two issues in this one.

[waspennator]

Xml.settings stubbed by #10178

[waspennator]

Tested out again as of the latest nightly, while the armor games logo does play twice, there are two new bugs i've noticed.

1: You can start a new game and toss the plane to begin a run, but as soon as the plane comes to a complete stop, the stats page that's supposed to show up normally never does, essentially soft locking the game.

www.kongregate.com-1679102742718.log

2: If you click on new game or load game and then back out, the game freaks out and softlocks on the preloader spamming this in the log.

Error occured when running AVM2 frame script: RustError("ArgumentError: Cannot remove object from display list it is not a child of.")

[waspennator]

Very weird, so tried out the version of Flight reported with #10443 and that version of Flight doesn't get stuck at the end of a run, while this one does, same for running the Kongregate version on desktop.

It also seems to get stuck not showing the results screen after your plane stops on the ruffle web demo too.

ruffle.rs-1680496593904.log

Update: Actually it seems like the Kongregate version is wonky on flash player too, needs the right click and play trick to get past the preloader and breaks trying to start a run, rechecking it seems like the Kongregate version is V K.1, while the other issue report is version 2.0

Update 2: According to Nosamu, it seems like its only playable if you load it via it's url on Flash player, game still seems to be buggy at times.

[Lord-McSweeney]

This uses TLF text libraries that vomit errors when attempting to load them in Ruffle. It doesn't actually seem to use TLF text anywhere though. The errors disappear with #13226 (though the PR doesn't change anything visibly).

[MartySVK]

The game works, but the Upgrade menu is broken:

ERROR core/src/display_object/movie_clip.rs:2712 Error occurred when running AVM2 frame script: TypeError: Error #1009: Cannot access a property or method of a null object reference. (accessing field: 0)
at Flight_fla::UpgradeButton_156/setTip()
at Flight_fla::UpgradeButton_156/init()
at UpgradeScreen/frame1()
at flash.display::MovieClip/flash::display::MovieClip::gotoAndStop()
at Flight_fla::MainTimeline/endTrans()
at Transit/frame3()