search

ruffsl / ros_docker_demos

A collection of Docker demos for ROS
111 stars 24 forks source link

new networking method for docker-compose #2

Open Roboticom314 opened 8 years ago

Roboticom314 commented 8 years ago

In the README.md for the multicontainer version, an example is given using docker-compose. The first command ($ docker-compose --x-networking up -d ) doesn't seem to work with recent versions of docker. I'm using docker-compose version 1.8.0 on ubuntu 14.04.4.

It may be that the --x-networking option has been deprecated in favor of the new version 2 compose file format.

ruffsl commented 8 years ago

Indeed it has. I've updated the docs on the official Docker Hub repo for ROS, but have somewhat neglected my own demo examples. If there is anything else that has become deprecated, please let me know so that when I get the time I can refresh this repo in one go.

Roboticom314 commented 8 years ago

Will do. It's a great starting point though.

It might be nice to add a demo here for using custom ROS package install output (from catkin_make install) in a custom docker image. Reference to setting up a private registry would be handy too. I think after that information, one could confidently create and distribute custom ROS packages in docker images.

huamichaelchen commented 5 years ago

First of all, great tutorial !!! Learned so much :) And just help others, here the version 2 docker-compose yml file that worked like a charm :) 

version: "2"

services:
  master:
    build: .
    container_name: master
    command:
      - roscore

  talker:
    build: .
    container_name: talker
    environment:
      - "ROS_HOSTNAME=talker"
      - "ROS_MASTER_URI=http://master:11311"
    command: rosrun roscpp_tutorials talker

  listener:
    build: .
    container_name: listener
    environment:
      - "ROS_HOSTNAME=listener"
      - "ROS_MASTER_URI=http://master:11311"
    command: rosrun roscpp_tutorials listener

And here is my docker CE version Docker version 18.09.0, build 4d60db4