search

ruflin / Elastica

Elastica is a PHP client for elasticsearch
http://elastica.io/
MIT License
2.26k stars 736 forks source link

Update changelog for 7.3.1 release #2156

Closed ruflin closed 1 year ago

ruflin commented 1 year ago

@VincentLanglet I just opened this PR to do a release but it seems to fail with PHPStan

Run vendor/bin/phpstan analyse --no-progress --error-format=github
Note: Using configuration file /home/runner/work/Elastica/Elastica/phpstan.neon.
Error: Ignored error pattern #^Expression on left side of \?\? is not nullable\.$# in path /home/runner/work/Elastica/Elastica/src/Client.php was not matched in reported errors.
Error: Process completed with exit code 1.

If I remember correctly, on your last PR all was fine. Do you have an idea on what happened here?

VincentLanglet commented 1 year ago

Hi This might have be a false positive added to the baseline, and recently fixed by a new Phpstan version. I would just remove https://github.com/ruflin/Elastica/blob/7.x/phpstan-baseline.neon#L3-L6 from the baseline :)

ruflin commented 1 year ago

@VincentLanglet That got it fixed, thanks