search

ruflin / Elastica

Elastica is a PHP client for elasticsearch
http://elastica.io/
MIT License
2.26k stars 736 forks source link

Update Makefile - Getting ready for docker compose V1 deprecation. #2160

Closed tevesm closed 1 year ago

tevesm commented 1 year ago

Getting ready for docker compose V1 deprecation. https://docs.docker.com/compose/migrate/

This update to Makefile will check if composer V2 is present and apply correct docker compose cmd syntax, otherwise it will keep current docker-compose cmd syntax.

ruflin commented 1 year ago

Thanks for the cleanup / future proofing.

tevesm commented 1 year ago

Hey no worries, just came across cmd syntax that will fail once docker compose V2 is on your dev machines, maybe from a docker desktop upgrade.

Happy for being able to contribute.

Thanks

De: Nicolas Ruflin @.> Enviado: 17 de maio de 2023 14:24 Para: ruflin/Elastica @.> Cc: tevesm @.>; Author @.> Assunto: Re: [ruflin/Elastica] Update Makefile - Getting ready for docker compose V1 deprecation. (PR #2160)

Thanks for the cleanup / future proofing.

— Reply to this email directly, view it on GitHubhttps://github.com/ruflin/Elastica/pull/2160#issuecomment-1551496277, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASBZ63MWK3ZQU6LAIDDJGMLXGTNQDANCNFSM6AAAAAAYDPL37U. You are receiving this because you authored the thread.Message ID: @.***>