Remove JSONParseException and remove unused Reindex constants.

ruflin / Elastica

Elastica is a PHP client for elasticsearch

http://elastica.io/

MIT License

2.26k stars 736 forks source link

Remove JSONParseException and remove unused Reindex constants. #2167

Closed coreation closed 1 year ago

coreation commented 1 year ago

Changes

Used JsonException where the deprecated JSONParseException was used.
Removed usages of the latter and removed unused/deprecated constants in Reindex.php.

thePanz commented 1 year ago

Thanks @coreation , merged!

coreation commented 1 year ago

Thanks! I've opened a PR as per @ruflin 's request for the elasticsearch-php client. I think I can contribute some time to help out, but there's a bunch of information I'd need from more experienced contributors as the refactor isn't that straightforward. The PR can be viewed here @thePanz . Let's do this!

ruflin commented 1 year ago

One nit on this PR: Changelog is missing ;-) @coreation Would be great to have a follow up PR for it so we don't forget.

coreation commented 1 year ago

@ruflin no problem, I made a new PR here. I fixed a small typo in a doc block as well. I wasn't sure where to add my changes, but I think the "Removed" section sounded appropriate ^^