ruflin / Elastica

Elastica is a PHP client for elasticsearch
http://elastica.io/
MIT License
2.26k stars 736 forks source link

[6.x] Allow psr/log v2 and v3 #2183

Open aistis- opened 11 months ago

aistis- commented 11 months ago

Seems we allow psr/log v2 or v3 to elastica v7+. This is a backport support for elastica v6. No changes from the code itself is necessary.

ruflin commented 11 months ago

Thanks for the contribution @aistis- I'm happy to get this in but please we aware that there are no other releases planned for 6.x at the moment.

ruflin commented 11 months ago

@aistis- Some of the CI tests are failing. I don't think this is because of your change but because some parts in the geo lib have been updated. It needs an adjustment in at least on of the test for the geo values.

aistis- commented 11 months ago

Hi @ruflin and thanks for feedback! Should I look into the failing tests and try to fix them? Indeed, they seems broken, but not because of added psr/log v2/3 support.

ruflin commented 11 months ago

Should I look into the failing tests and try to fix them?

That would be great! I hope it is mostly about adjusting some values.