DockerPHP AllowSymfonyFlexPlugin on phpuser for phpunit

ruflin / Elastica

Elastica is a PHP client for elasticsearch

http://elastica.io/

MIT License

2.26k stars 736 forks source link

DockerPHP AllowSymfonyFlexPlugin on phpuser for phpunit #2194

Closed daminuxfork closed 8 months ago

daminuxfork commented 8 months ago

Allow (to false) SymfonyFlex plugin for phpuser on make docker-run-phpunit

Love tests on docker ;)

ruflin commented 8 months ago

Can you share a bit more background (link or comment) on what this exactly does / allows?

daminuxfork commented 8 months ago

Can you share a bit more background (link or comment) on what this exactly does / allows?

As noted, I really like the idea of docker fulfilling its role of abstracting the host's technical stack.

After recovering the projects to work on the unit testing part, I executed make docker-start, then make docker-run-phpunit and I encountered this error, for which I propose this fix (see screenshot below).

ruflin commented 8 months ago

My initial reaction was, it seems like this is the wrong place but I just found out, 4 years ago we added this dependency to the project :-) https://github.com/ruflin/Elastica/blob/8bcb02d428fa4e5c472175166bc56a5a39b5c97b/Makefile#L19

daminuxfork commented 8 months ago

Done ! sorry mistake bad group of changes

daminuxfork commented 8 months ago

move type of changes ok.

ruflin commented 8 months ago

@daminuxfork Thank you for the contribution!