PHP 8.3 support please - Githubissues

ruflin / Elastica

Elastica is a PHP client for elasticsearch

http://elastica.io/

MIT License

2.26k stars 733 forks source link

PHP 8.3 support please #2200

Closed DavidGarciaCat closed 3 months ago

DavidGarciaCat commented 3 months ago

Good day,

I am working on an upgrade for a Symfony API which uses this Elastica Bundle. The new code is powered by PHP 8.3, which seems incompatible with the existing version restrictions/requirements.

Are there any short-term plans to support the new version?

Otherwise, some advice might be helpful for me or someone else to contribute and add support for the new version.

Thanks,

VincentLanglet commented 3 months ago

Hi, why do you think PHP 8.3 is not supported ?

In 8.x it's allowed https://github.com/ruflin/Elastica/blob/8.x/composer.json#L18
In 7.x also https://github.com/ruflin/Elastica/blob/7.x/composer.json#L18

DavidGarciaCat commented 3 months ago

Answering your question, “I think it's not supported” because I read the README and it says this (as you can see, the rule is “>=8.0 <8.2”):

VincentLanglet commented 3 months ago

The readme is just not up to date. There is CI on 8.3 https://github.com/ruflin/Elastica/commit/85e36c86d3f5816126d8bf1242c5edf8f4a247be

DavidGarciaCat commented 3 months ago

Understood. Thanks for the update.

But I hope you understand why I was opening this issue and what led me to the (apparent) wrong conclusion :-)

Enjoy the rest of your weekend!