search

ruflin / Elastica

Elastica is a PHP client for elasticsearch
http://elastica.io/
MIT License
2.26k stars 733 forks source link

Drop ES 7 from the pipeline #2204

Closed sidz closed 3 months ago

sidz commented 3 months ago

This PR drops testing 8.x branch with ES 7 as we don't support it anymore

ruflin commented 3 months ago

Can we keep the test for 7.x around until we actually break it? For migration purpose, it is kind of nice to know Elastica still works with 7.last. I suggest to add a line to the code you removed and the testing, that this is here because of backward compatibility but not officially supported. As soon as we hit a change where there is extra work to keep compatibility, we remove the code. On the docs, we should always state that it is not officially supported.

sidz commented 3 months ago

Fine with me @ruflin. I'll amend PR later today

ruflin commented 3 months ago

Thanks, I adjusted the commit message a bit to make it clear we didn't drop it.